]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
jbd2: Convert jbd2_write_superblock() to bh_submit()
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Thu, 28 May 2026 17:31:30 +0000 (18:31 +0100)
committerChristian Brauner <brauner@kernel.org>
Thu, 4 Jun 2026 08:28:08 +0000 (10:28 +0200)
Avoid an extra indirect function call and changing the buffer refcount
by using bh_submit() instead of submit_bh().

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Link: https://patch.msgid.link/20260528173150.1093780-18-willy@infradead.org
Acked-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
fs/jbd2/journal.c

index 4f397fcdb13c51494added4bdd6026546b7ed5d5..2040af8c84cb8fd94e7fd2ec61435f0b0caa2ffe 100644 (file)
@@ -1820,9 +1820,7 @@ static int jbd2_write_superblock(journal_t *journal, blk_opf_t write_flags)
        }
        if (jbd2_journal_has_csum_v2or3(journal))
                sb->s_checksum = jbd2_superblock_csum(sb);
-       get_bh(bh);
-       bh->b_end_io = end_buffer_write_sync;
-       submit_bh(REQ_OP_WRITE | write_flags, bh);
+       bh_submit(bh, REQ_OP_WRITE | write_flags, bh_end_write);
        wait_on_buffer(bh);
        if (buffer_write_io_error(bh)) {
                clear_buffer_write_io_error(bh);