]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: dsa: Do not make user port errors fatal
authorFlorian Fainelli <f.fainelli@gmail.com>
Mon, 4 May 2020 03:50:57 +0000 (20:50 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 May 2020 06:18:32 +0000 (08:18 +0200)
commit 86f8b1c01a0a537a73d2996615133be63cdf75db upstream.

Prior to 1d27732f411d ("net: dsa: setup and teardown ports"), we would
not treat failures to set-up an user port as fatal, but after this
commit we would, which is a regression for some systems where interfaces
may be declared in the Device Tree, but the underlying hardware may not
be present (pluggable daughter cards for instance).

Fixes: 1d27732f411d ("net: dsa: setup and teardown ports")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/dsa/dsa2.c

index 46ae4dee522ada29112abea5ecc49a2d40f1394f..b036c55f5cb1d6e30092b9084881daadf4195a67 100644 (file)
@@ -412,7 +412,7 @@ static int dsa_tree_setup_switches(struct dsa_switch_tree *dst)
 
                err = dsa_switch_setup(ds);
                if (err)
-                       return err;
+                       continue;
 
                for (port = 0; port < ds->num_ports; port++) {
                        dp = &ds->ports[port];