]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: adc: nxp-sar-adc: zero-initialize dma_slave_config
authorShuvam Pandey <shuvampandey1@gmail.com>
Mon, 6 Apr 2026 09:53:24 +0000 (15:38 +0545)
committerJonathan Cameron <jic23@kernel.org>
Fri, 15 May 2026 11:01:38 +0000 (12:01 +0100)
nxp_sar_adc_start_cyclic_dma() only fills the RX-side members of
dma_slave_config before passing it to dmaengine_slave_config().

Zero-initialize the structure so unused members do not contain stack
garbage. Some DMA engines consult optional dma_slave_config fields, so
leaving them uninitialized can cause DMA setup failures.

Fixes: 4434072a893e ("iio: adc: Add the NXP SAR ADC support for the s32g2/3 platforms")
Signed-off-by: Shuvam Pandey <shuvampandey1@gmail.com>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/adc/nxp-sar-adc.c

index 1711cae7d872a10bb612e74551dc21bbca5eb2ff..8f4ed3db94f07adbdbbeb67adb515ac850d6fdc7 100644 (file)
@@ -676,7 +676,7 @@ static void nxp_sar_adc_dma_cb(void *data)
 static int nxp_sar_adc_start_cyclic_dma(struct iio_dev *indio_dev)
 {
        struct nxp_sar_adc *info = iio_priv(indio_dev);
-       struct dma_slave_config config;
+       struct dma_slave_config config = { };
        struct dma_async_tx_descriptor *desc;
        int ret;