]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
lib/dns/tests/rbt_serialize_test.c: Fix dereference before DbC check
authorOndřej Surý <ondrej@sury.org>
Fri, 27 Sep 2019 09:40:44 +0000 (11:40 +0200)
committerOndřej Surý <ondrej@sury.org>
Thu, 3 Oct 2019 07:50:26 +0000 (09:50 +0200)
(cherry picked from commit 14c174d9212f0c8c9598d21e205d5d7380c54969)

lib/dns/tests/rbt_serialize_test.c

index 2208c0d8e70fda37c714a3983e6faf911d12b752..51ebffc5b3448c5545a62a0fc50154813b7e4a19 100644 (file)
@@ -173,7 +173,7 @@ write_data(FILE *file, unsigned char *datap, void *arg, uint64_t *crc) {
 
 static isc_result_t
 fix_data(dns_rbtnode_t *p, void *base, size_t max, void *arg, uint64_t *crc) {
-       data_holder_t *data = p->data;
+       data_holder_t *data;
        size_t size;
 
        UNUSED(base);
@@ -183,6 +183,7 @@ fix_data(dns_rbtnode_t *p, void *base, size_t max, void *arg, uint64_t *crc) {
        REQUIRE(crc != NULL);
        REQUIRE(p != NULL);
 
+       data = p->data;
 
        if (data == NULL ||
            (data->len == 0 && data->data != NULL) ||