io_uring: fix spurious fput in registered ring path

Fix an issue with io_uring_ctx_get_file() not gating fput() on whether
or not the file descriptor is a registered/direct one or not.

Fixes: c5e9f6a96bf7 ("io_uring: unify getting ctx from passed in file descriptor")
Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index dd6326dc5f88f9d68b7395b5cd8109e9fdf9a6a4..4ed998d60c09cb0706d23ce5e9a5c9da5e282607 100644 (file)
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -2575,7 +2575,8 @@ struct file *io_uring_ctx_get_file(unsigned int fd, bool registered)
                return ERR_PTR(-EBADF);
        if (io_is_uring_fops(file))
                return file;
-       fput(file);
+       if (!registered)
+               fput(file);
        return ERR_PTR(-EOPNOTSUPP);
 }