]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
realtek: fix LED function for XS1930 switches
authorJonas Jelonek <jelonek.jonas@gmail.com>
Mon, 18 May 2026 09:01:11 +0000 (09:01 +0000)
committerRobert Marko <robimarko@gmail.com>
Thu, 21 May 2026 10:08:42 +0000 (12:08 +0200)
The cloud and locator LEDs were declared with no function (cloud) or
with the generic LED_FUNCTION_INDICATOR (locator), which doesn't
match what the hardware actually exposes. Use the descriptive
function strings "cloud" and "locator" instead so the LEDs end up
with sensible names in sysfs.

Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/23428
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/realtek/dts/rtl9313_zyxel_xs1930.dtsi

index 2523740f632da44d927e5a3d63919e059c4afb48..d5fa56bc06a0ab47406f4aa7e3d4a92b33dfceaf 100644 (file)
                };
                led_cloud_green: led-4 {
                        color = <LED_COLOR_ID_GREEN>;
+                       function = "cloud";
                        gpios = <&gpio0 24 GPIO_ACTIVE_LOW>;
                };
                led_cloud_red: led-5 {
                        color = <LED_COLOR_ID_RED>;
+                       function = "cloud";
                        gpios = <&gpio0 25 GPIO_ACTIVE_LOW>;
                };
                led_locator: led-6 {
                        color = <LED_COLOR_ID_BLUE>;
-                       function = LED_FUNCTION_INDICATOR;
+                       function = "locator";
                        gpios = <&gpio0 26 GPIO_ACTIVE_LOW>;
                };
        };