]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
fbdev: pxa168fb: use devm_ioremap_resource() for MMIO
authorAlbertoArostegui <aarosteguig@gmail.com>
Wed, 27 May 2026 15:39:13 +0000 (15:39 +0000)
committerHelge Deller <deller@gmx.de>
Tue, 9 Jun 2026 14:00:10 +0000 (16:00 +0200)
pxa168fb maps the LCD controller register resource with devm_ioremap(),
which does not request the memory region. Use devm_ioremap_resource()
instead so the MMIO range is claimed before being mapped.

This also handles cleanup automatically.

Signed-off-by: AlbertoArostegui <aarosteguig@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/pxa168fb.c

index ec602f7776eb03105d8ce0cc1b582d40ca6dab40..6784888d93c9f4ba434c1fe06c167ec27e8ef4c4 100644 (file)
@@ -653,10 +653,9 @@ static int pxa168fb_probe(struct platform_device *pdev)
        /*
         * Map LCD controller registers.
         */
-       fbi->reg_base = devm_ioremap(&pdev->dev, res->start,
-                                            resource_size(res));
-       if (fbi->reg_base == NULL) {
-               ret = -ENOMEM;
+       fbi->reg_base = devm_ioremap_resource(&pdev->dev, res);
+       if (IS_ERR(fbi->reg_base)) {
+               ret = PTR_ERR(fbi->reg_base);
                goto failed_free_info;
        }