Disable inactive handles caching when compiled with sanitizers

When isc_nmhandle_t gets deactivated, it could be just put onto array
stack to be reused later to safe some initialization time.
Unfortunately, this might hide some use-after-free errors.

Disable the inactive handles caching when compiled with Address or
Thread Sanitizer.

diff --git a/lib/isc/netmgr/netmgr.c b/lib/isc/netmgr/netmgr.c
index 0e8a4918316975403aece663399605e07ebb4efa..0c906e69b98dc146147c3e93a98c1251e804c10c 100644 (file)
--- a/lib/isc/netmgr/netmgr.c
+++ b/lib/isc/netmgr/netmgr.c
@@ -1753,9 +1753,11 @@ nmhandle_deactivate(isc_nmsocket_t *sock, isc_nmhandle_t *handle) {
 
        INSIST(atomic_fetch_sub(&sock->ah, 1) > 0);
 
+#if !__SANITIZE_ADDRESS && !__SANITIZE_THREAD__
        if (atomic_load(&sock->active)) {
                reuse = isc_astack_trypush(sock->inactivehandles, handle);
        }
+#endif /* !__SANITIZE_ADDRESS && !__SANITIZE_THREAD__ */
        if (!reuse) {
                nmhandle_free(sock, handle);
        }