]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuDomainSetIOThreadParams: Move typed parameter validation to top level
authorPeter Krempa <pkrempa@redhat.com>
Thu, 23 Apr 2026 08:51:22 +0000 (10:51 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 14 May 2026 10:13:10 +0000 (12:13 +0200)
This will allow introspecting them.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c

index 3d44c6d9602e78b99e8d76cb9fbf30a80beba639..264799a8645c76eaa94c0d9089af4b47626e553e 100644 (file)
@@ -5323,20 +5323,6 @@ qemuDomainIOThreadParseParams(virTypedParameterPtr params,
 {
     int rc;
 
-    if (virTypedParamsValidate(params, nparams,
-                               VIR_DOMAIN_IOTHREAD_POLL_MAX_NS,
-                               VIR_TYPED_PARAM_ULLONG,
-                               VIR_DOMAIN_IOTHREAD_POLL_GROW,
-                               VIR_TYPED_PARAM_UNSIGNED,
-                               VIR_DOMAIN_IOTHREAD_POLL_SHRINK,
-                               VIR_TYPED_PARAM_UNSIGNED,
-                               VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN,
-                               VIR_TYPED_PARAM_INT,
-                               VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX,
-                               VIR_TYPED_PARAM_INT,
-                               NULL) < 0)
-        return -1;
-
     if ((rc = virTypedParamsGetULLong(params, nparams,
                                       VIR_DOMAIN_IOTHREAD_POLL_MAX_NS,
                                       &iothread->poll_max_ns)) < 0)
@@ -5679,6 +5665,20 @@ qemuDomainSetIOThreadParams(virDomainPtr dom,
     virCheckFlags(VIR_DOMAIN_AFFECT_LIVE |
                   VIR_DOMAIN_AFFECT_CONFIG, -1);
 
+    if (virTypedParamsValidate(params, nparams,
+                               VIR_DOMAIN_IOTHREAD_POLL_MAX_NS,
+                               VIR_TYPED_PARAM_ULLONG,
+                               VIR_DOMAIN_IOTHREAD_POLL_GROW,
+                               VIR_TYPED_PARAM_UNSIGNED,
+                               VIR_DOMAIN_IOTHREAD_POLL_SHRINK,
+                               VIR_TYPED_PARAM_UNSIGNED,
+                               VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN,
+                               VIR_TYPED_PARAM_INT,
+                               VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX,
+                               VIR_TYPED_PARAM_INT,
+                               NULL) < 0)
+        return -1;
+
     if (iothread_id == 0) {
         virReportError(VIR_ERR_INVALID_ARG, "%s",
                        _("invalid value of 0 for iothread_id"));