]> git.ipfire.org Git - thirdparty/gnutls.git/commitdiff
certtool: tighten allocation check
authorDaiki Ueno <ueno@gnu.org>
Tue, 11 May 2021 12:13:45 +0000 (14:13 +0200)
committerDaiki Ueno <ueno@gnu.org>
Tue, 11 May 2021 12:13:57 +0000 (14:13 +0200)
Spotted by gcc analyzer:
  certtool-cfg.c:856:24: warning: use of possibly-NULL 'copy' where non-null expected [CWE-690] [-Wanalyzer-possible-null-argument]
    856 |                 while (strcmp(pass, copy) != 0
        |                        ^~~~~~~~~~~~~~~~~~

Signed-off-by: Daiki Ueno <ueno@gnu.org>
src/certtool-cfg.c

index a8103cb837cfdb2e111ae8362d83b989458cb218..8c658c86672233a432b3dceada170139982c63e3 100644 (file)
@@ -851,6 +851,7 @@ const char *get_confirmed_pass(bool empty_ok)
 
                        pass = getpass("Enter password: ");
                        copy = strdup(pass);
+                       CHECK_MALLOC(copy);
                        pass = getpass("Confirm password: ");
                }
                while (strcmp(pass, copy) != 0