]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
crypto/aes/asm/asm-sha{1,256}-armv8.pl: add missing function alignment
authorNikola Pajkovsky <nikolap@openssl.org>
Mon, 25 May 2026 07:33:00 +0000 (09:33 +0200)
committerEugene Syromiatnikov <esyr@openssl.org>
Thu, 28 May 2026 08:19:38 +0000 (10:19 +0200)
clang-22 reported missing alignment on MacOS:

    ld: warning: arm64 function not 4-byte aligned: _asm_sha1_hmac_aescbc_dec from libcrypto.a(libcrypto-lib-aes-sha1-armv8.o)
    ld: warning: arm64 function not 4-byte aligned: _asm_sha256_hmac_aescbc_dec from libcrypto.a(libcrypto-lib-aes-sha256-armv8.o)

Add ".align 4" directives to the affected functions.

Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.foundation>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
MergeDate: Thu May 28 08:31:59 2026
(Merged from https://github.com/openssl/openssl/pull/31284)

crypto/aes/asm/aes-sha1-armv8.pl
crypto/aes/asm/aes-sha256-armv8.pl

index e965811b718365c62a1a5eca252d30219269b85c..251c9bff3ca7f1cfd37f698adc222e592a8519d1 100644 (file)
@@ -2395,6 +2395,7 @@ $code.=<<___;
 
 .global asm_sha1_hmac_aescbc_dec
 .type  asm_sha1_hmac_aescbc_dec,%function
+.align 4
 
 asm_sha1_hmac_aescbc_dec:
        AARCH64_VALID_CALL_TARGET
index f81f590090ab5c1d60f4b8b51be6d0e2a5afe8a6..9e403c3abfd460e78fce981ef773bca3ddaa5c30 100644 (file)
@@ -2555,6 +2555,7 @@ $code.=<<___;
 
 .global        asm_sha256_hmac_aescbc_dec
 .type  asm_sha256_hmac_aescbc_dec,%function
+.align  4
 
 asm_sha256_hmac_aescbc_dec:
        AARCH64_VALID_CALL_TARGET
@@ -4655,4 +4656,4 @@ if ($flavour =~ /64/) {
        }
 }
 
-close STDOUT or die "error closing STDOUT: $!";
\ No newline at end of file
+close STDOUT or die "error closing STDOUT: $!";