pinctrl: cy8c95x0: remove duplicate error message

The pin control core is covered to report any error via message.
The devm_request_threaded_irq() already prints an error message.
Remove the duplicates.

While at it, drop the info message as the same information about
an IRQ in use can be retrieved differently.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>

diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c
index a562c5307de811c3738a23a91a46836aefbeb893..86d65c51dd9bcea1fc6c3453a31442c891eb3115 100644 (file)
--- a/drivers/pinctrl/pinctrl-cy8c95x0.c
+++ b/drivers/pinctrl/pinctrl-cy8c95x0.c
@@ -1310,6 +1310,7 @@ static int cy8c95x0_irq_setup(struct cy8c95x0_pinctrl *chip, int irq)
 {
        struct gpio_irq_chip *girq = &chip->gpio_chip.irq;
        DECLARE_BITMAP(pending_irqs, MAX_LINE);
+       struct device *dev = chip->dev;
        int ret;
 
        ret = devm_mutex_init(chip->dev, &chip->irq_lock);
@@ -1338,17 +1339,9 @@ static int cy8c95x0_irq_setup(struct cy8c95x0_pinctrl *chip, int irq)
        girq->handler = handle_simple_irq;
        girq->threaded = true;
 
-       ret = devm_request_threaded_irq(chip->dev, irq,
-                                       NULL, cy8c95x0_irq_handler,
-                                       IRQF_ONESHOT | IRQF_SHARED,
-                                       dev_name(chip->dev), chip);
-       if (ret) {
-               dev_err(chip->dev, "failed to request irq %d\n", irq);
-               return ret;
-       }
-       dev_info(chip->dev, "Registered threaded IRQ\n");
-
-       return 0;
+       return devm_request_threaded_irq(dev, irq, NULL, cy8c95x0_irq_handler,
+                                        IRQF_ONESHOT | IRQF_SHARED,
+                                        dev_name(chip->dev), chip);
 }
 
 static int cy8c95x0_setup_pinctrl(struct cy8c95x0_pinctrl *chip)
@@ -1364,11 +1357,7 @@ static int cy8c95x0_setup_pinctrl(struct cy8c95x0_pinctrl *chip)
        pd->owner = THIS_MODULE;
 
        chip->pctldev = devm_pinctrl_register(chip->dev, pd, chip);
-       if (IS_ERR(chip->pctldev))
-               return dev_err_probe(chip->dev, PTR_ERR(chip->pctldev),
-                       "can't register controller\n");
-
-       return 0;
+       return PTR_ERR_OR_ZERO(chip->pctldev);
 }
 
 static int cy8c95x0_detect(struct i2c_client *client,