3651. [tuning] Adjust when a master server is deemed unreachable.

                        [RT #27075]

diff --git a/CHANGES b/CHANGES
index 9c112cfe764375d82d0772422436f5585e26ed81..d1d6752790276751342516f5747d996a25187f3f 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+3651.  [tuning]        Adjust when a master server is deemed unreachable.
+                       [RT #27075]
+
 3650.  [tuning]        Use separate rate limiting queues for refresh and
                        notify requests. [RT #30589]
 

diff --git a/lib/dns/tests/zonemgr_test.c b/lib/dns/tests/zonemgr_test.c
index 7decde0c9b75da3cdd35c5b0ababc5574e6f58cf..62653186396dbc4aaf3eb70d1e23cdbd26e0c337 100644 (file)
--- a/lib/dns/tests/zonemgr_test.c
+++ b/lib/dns/tests/zonemgr_test.c
@@ -188,12 +188,23 @@ ATF_TC_BODY(zonemgr_unreachable, tc) {
        in.s_addr = inet_addr("10.53.0.2");
        isc_sockaddr_fromin(&addr2, &in, 5150);
        ATF_CHECK(! dns_zonemgr_unreachable(zonemgr, &addr1, &addr2, &now));
+       /*
+        * We require multiple unreachableadd calls to mark a server as
+        * unreachable.
+        */
+       dns_zonemgr_unreachableadd(zonemgr, &addr1, &addr2, &now);
+       ATF_CHECK(! dns_zonemgr_unreachable(zonemgr, &addr1, &addr2, &now));
        dns_zonemgr_unreachableadd(zonemgr, &addr1, &addr2, &now);
        ATF_CHECK(dns_zonemgr_unreachable(zonemgr, &addr1, &addr2, &now));
 
        in.s_addr = inet_addr("10.53.0.3");
        isc_sockaddr_fromin(&addr2, &in, 5150);
        ATF_CHECK(! dns_zonemgr_unreachable(zonemgr, &addr1, &addr2, &now));
+       /*
+        * We require multiple unreachableadd calls to mark a server as
+        * unreachable.
+        */
+       dns_zonemgr_unreachableadd(zonemgr, &addr1, &addr2, &now);
        dns_zonemgr_unreachableadd(zonemgr, &addr1, &addr2, &now);
        ATF_CHECK(dns_zonemgr_unreachable(zonemgr, &addr1, &addr2, &now));
 

diff --git a/lib/dns/xfrin.c b/lib/dns/xfrin.c
index 118e109659b0c51e23a00f7b24d6261c556bbf7d..08d71219519226eef2ee3011455d9b69aaf0def8 100644 (file)
--- a/lib/dns/xfrin.c
+++ b/lib/dns/xfrin.c
@@ -959,6 +959,8 @@ xfrin_connect_done(isc_task_t *task, isc_event_t *event) {
        isc_result_t result = cev->result;
        char sourcetext[ISC_SOCKADDR_FORMATSIZE];
        isc_sockaddr_t sockaddr;
+       dns_zonemgr_t * zmgr;
+       isc_time_t now;
 
        REQUIRE(VALID_XFRIN(xfr));
 
@@ -973,16 +975,16 @@ xfrin_connect_done(isc_task_t *task, isc_event_t *event) {
                return;
        }
 
-       if (result != ISC_R_SUCCESS) {
-               dns_zonemgr_t * zmgr = dns_zone_getmgr(xfr->zone);
-               isc_time_t now;
-
-               if (zmgr != NULL) {
+       zmgr = dns_zone_getmgr(xfr->zone);
+       if (zmgr != NULL) {
+               if (result != ISC_R_SUCCESS) {
                        TIME_NOW(&now);
                        dns_zonemgr_unreachableadd(zmgr, &xfr->masteraddr,
                                                   &xfr->sourceaddr, &now);
-               }
-               goto failure;
+                       goto failure;
+               } else
+                       dns_zonemgr_unreachabledel(zmgr, &xfr->masteraddr,
+                                                  &xfr->sourceaddr);
        }
 
        result = isc_socket_getsockname(xfr->socket, &sockaddr);

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index 995c5013a1e67d4090dd80e9675f8bc4a8ebcb51..1d8499770ac90ceee2572b16993602036032494e 100644 (file)
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -468,6 +468,7 @@ struct dns_unreachable {
        isc_sockaddr_t  local;
        isc_uint32_t    expire;
        isc_uint32_t    last;
+       isc_uint32_t    count;
 };
 
 struct dns_zonemgr {
@@ -15405,6 +15406,7 @@ dns_zonemgr_unreachable(dns_zonemgr_t *zmgr, isc_sockaddr_t *remote,
        isc_rwlocktype_t locktype;
        isc_result_t result;
        isc_uint32_t seconds = isc_time_seconds(now);
+       isc_uint32_t count = 0;
 
        REQUIRE(DNS_ZONEMGR_VALID(zmgr));
 
@@ -15418,12 +15420,13 @@ dns_zonemgr_unreachable(dns_zonemgr_t *zmgr, isc_sockaddr_t *remote,
                        if (result == ISC_R_SUCCESS) {
                                locktype = isc_rwlocktype_write;
                                zmgr->unreachable[i].last = seconds;
+                               count = zmgr->unreachable[i].count;
                        }
                        break;
                }
        }
        RWUNLOCK(&zmgr->urlock, locktype);
-       return (ISC_TF(i < UNREACH_CHACHE_SIZE));
+       return (ISC_TF(i < UNREACH_CHACHE_SIZE && count > 1U));
 }
 
 void
@@ -15497,6 +15500,10 @@ dns_zonemgr_unreachableadd(dns_zonemgr_t *zmgr, isc_sockaddr_t *remote,
                 */
                zmgr->unreachable[i].expire = seconds + UNREACH_HOLD_TIME;
                zmgr->unreachable[i].last = seconds;
+               if (zmgr->unreachable[i].expire < seconds)
+                       zmgr->unreachable[i].count = 1;
+               else
+                       zmgr->unreachable[i].count++;
        } else if (slot != UNREACH_CHACHE_SIZE) {
                /*
                 * Found a empty slot. Add a new entry to the cache.
@@ -15505,6 +15512,7 @@ dns_zonemgr_unreachableadd(dns_zonemgr_t *zmgr, isc_sockaddr_t *remote,
                zmgr->unreachable[slot].last = seconds;
                zmgr->unreachable[slot].remote = *remote;
                zmgr->unreachable[slot].local = *local;
+               zmgr->unreachable[slot].count = 1;
        } else {
                /*
                 * Replace the least recently used entry in the cache.
@@ -15513,6 +15521,7 @@ dns_zonemgr_unreachableadd(dns_zonemgr_t *zmgr, isc_sockaddr_t *remote,
                zmgr->unreachable[oldest].last = seconds;
                zmgr->unreachable[oldest].remote = *remote;
                zmgr->unreachable[oldest].local = *local;
+               zmgr->unreachable[oldest].count = 1;
        }
        RWUNLOCK(&zmgr->urlock, isc_rwlocktype_write);
 }