]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
mod_ssl: fix set_challenge_creds() to return rv on failure
authorJoe Orton <jorton@apache.org>
Fri, 17 Jul 2026 12:12:40 +0000 (12:12 +0000)
committerJoe Orton <jorton@apache.org>
Fri, 17 Jul 2026 12:12:40 +0000 (12:12 +0000)
* modules/ssl/ssl_engine_kernel.c (set_challenge_creds): Return rv
  rather than APR_SUCCESS unconditionally, so credential setup
  failures are propagated to the ALPN selection callback.

Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
GitHub: PR #685

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1936262 13f79535-47bb-0310-9956-ffa450edef68

modules/ssl/ssl_engine_kernel.c

index 9ee25ec52ca068521aed90e245f68fbc9f6635d9..3e96f9efdac75962f77657d50ba53b0a9e28dd30 100644 (file)
@@ -2238,7 +2238,7 @@ static apr_status_t set_challenge_creds(conn_rec *c, const char *servername,
 cleanup:
     if (our_data && cert) X509_free(cert);
     if (our_data && key) EVP_PKEY_free(key);
-    return APR_SUCCESS;
+    return rv;
 }
   
 /*