]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix INSIST copy-paste error checking RADIX_V4 instead of RADIX_V6
authorOndřej Surý <ondrej@isc.org>
Wed, 11 Mar 2026 12:17:56 +0000 (13:17 +0100)
committerOndřej Surý <ondrej@isc.org>
Mon, 30 Mar 2026 17:01:29 +0000 (19:01 +0200)
The INSIST in isc_radix_insert() checks node->data[RADIX_V4] and
node->node_num[RADIX_V4] twice due to a copy-paste error, never
verifying the RADIX_V6 fields.

Fix the second pair to check RADIX_V6.

(cherry picked from commit 3f15f2d9e5968d6e03c4dc89cd7aea097f9c3ced)

lib/isc/radix.c

index 31cceed1b01c974f6de5f802b676a364afec05d2..a62fdde38c5b64689b717623f8b098967f953f4e 100644 (file)
@@ -458,8 +458,8 @@ isc_radix_insert(isc_radix_tree_t *radix, isc_radix_node_t **target,
                }
                INSIST(node->data[RADIX_V4] == NULL &&
                       node->node_num[RADIX_V4] == -1 &&
-                      node->data[RADIX_V4] == NULL &&
-                      node->node_num[RADIX_V4] == -1);
+                      node->data[RADIX_V6] == NULL &&
+                      node->node_num[RADIX_V6] == -1);
                if (source != NULL) {
                        /* Merging node */
                        for (i = 0; i < RADIX_FAMILIES; i++) {