Fix memory leak in dns_message_checksig() - SIG(0) sigs

Impact should be visible only in tests or tools because named never
uses view == NULL, which is a necessary condition to trigger this leak.

(cherry picked from commit 69256b3553d3b8b73b6fa4de9b030b39f1b96d34)

diff --git a/lib/dns/message.c b/lib/dns/message.c
index 547a13fef26658ba7887532a68de36f1056506af..dfa5891ba024440341abb1df01d871e6edde282d 100644 (file)
--- a/lib/dns/message.c
+++ b/lib/dns/message.c
@@ -3219,7 +3219,8 @@ dns_message_checksig(dns_message_t *msg, dns_view_t *view) {
 
                dns_rdataset_init(&keyset);
                if (view == NULL) {
-                       return (DNS_R_KEYUNAUTHORIZED);
+                       result = DNS_R_KEYUNAUTHORIZED;
+                       goto freesig;
                }
                result = dns_view_simplefind(view, &sig.signer,
                                             dns_rdatatype_key /* SIG(0) */, 0,