vsh: cmdComplete: Don't exit when connecting to the daemon fails

Invoke the 'connHandler' without checking return value. 'virsh complete'
can provide useful completions even when the daemon connection is
broken.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/tools/vsh.c b/tools/vsh.c
index c84d17a3327f6d49497e4634cee103c59cc91f58..ccf2f21d64c143d127cfcfd9b805ce331f99abff 100644 (file)
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -3584,8 +3584,11 @@ cmdComplete(vshControl *ctl, const vshCmd *cmd)
         ctl->stderr_closed = true;
     }
 
-    if (!(hooks && hooks->connHandler && hooks->connHandler(ctl)))
-        return false;
+    /* Attempt connecting so that we can also do completions based on e.g.
+     * object names work. Failure to connect is not fatal because we want
+     * at least argument completion */
+    if (hooks && hooks->connHandler)
+        ignore_value(hooks->connHandler(ctl));
 
     vshReadlineInit(ctl);