]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ALSA: usb-audio: qcom: Fix return value in qc_usb_audio_offload_fill_avail_pcms
authorwangdicheng <wangdicheng@kylinos.cn>
Wed, 3 Jun 2026 09:11:01 +0000 (17:11 +0800)
committerTakashi Iwai <tiwai@suse.de>
Thu, 4 Jun 2026 08:15:09 +0000 (10:15 +0200)
The function qc_usb_audio_offload_fill_avail_pcms() always returns -1
regardless of how many PCM devices were successfully filled. This makes
it impossible for callers to know the actual number of available PCMs.

Return the actual count of filled PCM devices instead, which allows
callers to verify that all expected PCMs were properly enumerated.

Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20260603091102.231370-3-wangdich9700@163.com
sound/usb/qcom/qc_audio_offload.c

index f99f8bddb2379545b1dcc32caa71c6d94062efea..fa7ee61d6934c3cd60284238723fd938f79e7781 100644 (file)
@@ -1753,7 +1753,7 @@ static int qc_usb_audio_offload_fill_avail_pcms(struct snd_usb_audio *chip,
                        break;
        }
 
-       return -1;
+       return idx;
 }
 
 /**