]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: cs35l56: Log SoundWire status updates only on changes
authorSimon Trimmer <simont@opensource.cirrus.com>
Thu, 14 May 2026 15:18:54 +0000 (16:18 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 15 May 2026 01:57:05 +0000 (10:57 +0900)
The SoundWire slave update_status() callback can be invoked when the
status has not changed. To prevent large amounts of log noise with debug
enabled, log them only when the status changes. This also helps with
understanding them, because they now log an actual change in state.

Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20260514151854.695145-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l56-sdw.c

index 9dc47fec1ea048caa0f4158d26206474cc132138..d344217de7aa62d224ef417cf7d01d5213edd0ab 100644 (file)
@@ -385,18 +385,19 @@ static int cs35l56_sdw_update_status(struct sdw_slave *peripheral,
 
        switch (status) {
        case SDW_SLAVE_ATTACHED:
-               dev_dbg(cs35l56->base.dev, "%s: ATTACHED\n", __func__);
                cs35l56->sdw_in_clock_stop_1 = false;
                if (cs35l56->sdw_attached)
                        break;
 
+               dev_dbg(cs35l56->base.dev, "%s: ATTACHED\n", __func__);
                if (!cs35l56->base.init_done || cs35l56->soft_resetting)
                        cs35l56_sdw_init(peripheral);
 
                cs35l56->sdw_attached = true;
                break;
        case SDW_SLAVE_UNATTACHED:
-               dev_dbg(cs35l56->base.dev, "%s: UNATTACHED\n", __func__);
+               if (cs35l56->sdw_attached)
+                       dev_dbg(cs35l56->base.dev, "%s: UNATTACHED\n", __func__);
                cs35l56->sdw_attached = false;
                break;
        default: