]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Check for proper log message in kasp test
authorTom Krizek <tkrizek@isc.org>
Thu, 22 Jun 2023 15:57:22 +0000 (17:57 +0200)
committerTom Krizek <tkrizek@isc.org>
Mon, 26 Jun 2023 11:08:09 +0000 (13:08 +0200)
The log message is supposed to contain the zone name which was
erroneously omitted, but didn't pop up during tests, since return code
was silently ignored.

Now it actually waits for the proper log message rather than being an
equivalent of 3 second sleep (which was also sufficient to make the test
pass, thus we detected no failure).

(cherry picked from commit 1dd4c2b9e2649f8dc41335e15180c0dc5ad4efbb)

bin/tests/system/kasp/tests.sh

index c2bf7e95e621ac77be3596e0d3ba75cfdba68771..fbb8bdc215b9a9e69b74d1487d5513d3f9673e79 100644 (file)
@@ -329,7 +329,7 @@ ret=0
 
 nextpart $DIR/named.run > /dev/null
 rndccmd 10.53.0.3 loadkeys "$ZONE" > /dev/null || log_error "rndc loadkeys zone ${ZONE} failed"
-wait_for_log 3 "keymgr: done" $DIR/named.run
+wait_for_log 3 "keymgr: $ZONE done" $DIR/named.run
 privkey_stat2=$(key_stat "${basefile}.private")
 pubkey_stat2=$(key_stat "${basefile}.key")
 state_stat2=$(key_stat "${basefile}.state")