cmd: host: fix duplicate device_unbind and wrong error message in unbind

do_host_unbind()'s error handler for device_unbind() prints the
misleading message "Cannot attach file" and then calls device_unbind()
a second time on the same device, both of which look like copy-paste
mistakes left over from neighbouring code.

Remove the duplicate device_unbind() call and report the correct
failure with the device name.

Fixes: 952018117ab ("dm: sandbox: Switch over to using the new host uclass")
Signed-off-by: Naveen Kumar Chaudhary <naveen.osdev@gmail.com>

diff --git a/cmd/host.c b/cmd/host.c
index e03576b4d2def808687a02f7db48d359a66426ef..47a59f5ff201b0ed73b78fa5328bd047531f6bac 100644 (file)
--- a/cmd/host.c
+++ b/cmd/host.c
@@ -132,10 +132,7 @@ static int do_host_unbind(struct cmd_tbl *cmdtp, int flag, int argc,
 
        ret = device_unbind(dev);
        if (ret) {
-               printf("Cannot attach file\n");
-               ret = device_unbind(dev);
-               if (ret)
-                       printf("Cannot unbind device '%s'\n", dev->name);
+               printf("Cannot unbind device '%s'\n", dev->name);
                return CMD_RET_FAILURE;
        }