]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: Increment our metrics in a consistent order to appease Miod! 17102/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 2 Apr 2026 10:18:55 +0000 (12:18 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 2 Apr 2026 10:18:55 +0000 (12:18 +0200)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
pdns/dnsdistdist/dnsdist.cc

index 1475553932a24fb518b12d6597e1de4c0c6ac4d6..5322c0df09311d0a09c4dccddb3de4e083ae4a42 100644 (file)
@@ -1309,8 +1309,8 @@ static bool isUDPQueryAcceptable(ClientState& clientState, const struct msghdr*
     /* message was too large for our buffer */
     VERBOSESLOG(infolog("Dropping message too large for our buffer"),
                 dnsdist::logging::getTopLogger("udp-query")->info(Logr::Info, "Dropping query from client that is too large for our buffer", "client.address", Logging::Loggable(remote), "destination.address", Logging::Loggable(dest), "frontend.address", Logging::Loggable(clientState.local)));
-    ++clientState.nonCompliantQueries;
     ++dnsdist::metrics::g_stats.nonCompliantQueries;
+    ++clientState.nonCompliantQueries;
     return false;
   }
 
@@ -2313,8 +2313,8 @@ static void MultipleMessagesUDPClientThread(ClientState* clientState)
 
       if ((msgh->msg_flags & MSG_TRUNC) != 0) {
         /* message was too large for our buffer */
-        ++clientState->nonCompliantQueries;
         ++dnsdist::metrics::g_stats.nonCompliantQueries;
+        ++clientState->nonCompliantQueries;
         continue;
       }