ensure fd is non-negative before calling dup()

this silences a spurious warning from clang-scan 19.

diff --git a/lib/isc/netmgr/tcp.c b/lib/isc/netmgr/tcp.c
index 37d44bd9c846a3334eed1eba1b483f429f73e028..7c77b6cb744522f4a6be825fee1822431a2372a7 100644 (file)
--- a/lib/isc/netmgr/tcp.c
+++ b/lib/isc/netmgr/tcp.c
@@ -424,9 +424,10 @@ start_tcp_child(isc_nm_t *mgr, isc_sockaddr_t *iface, isc_nmsocket_t *sock,
                csock->fd = isc__nm_tcp_lb_socket(mgr,
                                                  iface->type.sa.sa_family);
        } else {
+               INSIST(fd >= 0);
                csock->fd = dup(fd);
        }
-       REQUIRE(csock->fd >= 0);
+       INSIST(csock->fd >= 0);
 
        ievent = isc__nm_get_netievent_tcplisten(mgr, csock);
        isc__nm_maybe_enqueue_ievent(&mgr->workers[tid],

diff --git a/lib/isc/netmgr/tcpdns.c b/lib/isc/netmgr/tcpdns.c
index 4b5ee58b6a59e3e9ff753ef0f8851254884dd2f7..6ce4a61e686adf6386078c053100ec43a253dd86 100644 (file)
--- a/lib/isc/netmgr/tcpdns.c
+++ b/lib/isc/netmgr/tcpdns.c
@@ -397,9 +397,10 @@ start_tcpdns_child(isc_nm_t *mgr, isc_sockaddr_t *iface, isc_nmsocket_t *sock,
                csock->fd = isc__nm_tcpdns_lb_socket(mgr,
                                                     iface->type.sa.sa_family);
        } else {
+               INSIST(fd >= 0);
                csock->fd = dup(fd);
        }
-       REQUIRE(csock->fd >= 0);
+       INSIST(csock->fd >= 0);
 
        ievent = isc__nm_get_netievent_tcpdnslisten(mgr, csock);
        isc__nm_maybe_enqueue_ievent(&mgr->workers[tid],

diff --git a/lib/isc/netmgr/tlsdns.c b/lib/isc/netmgr/tlsdns.c
index dcec05347f787460033b453d52ba01f937707a23..b56e0682b1fee4bda358c3527f9ca562280d35ca 100644 (file)
--- a/lib/isc/netmgr/tlsdns.c
+++ b/lib/isc/netmgr/tlsdns.c
@@ -501,9 +501,10 @@ start_tlsdns_child(isc_nm_t *mgr, isc_sockaddr_t *iface, isc_nmsocket_t *sock,
                csock->fd = isc__nm_tlsdns_lb_socket(mgr,
                                                     iface->type.sa.sa_family);
        } else {
+               INSIST(fd >= 0);
                csock->fd = dup(fd);
        }
-       REQUIRE(csock->fd >= 0);
+       INSIST(csock->fd >= 0);
 
        ievent = isc__nm_get_netievent_tlsdnslisten(mgr, csock);
        isc__nm_maybe_enqueue_ievent(&mgr->workers[tid],

diff --git a/lib/isc/netmgr/udp.c b/lib/isc/netmgr/udp.c
index 661de96ac69567d5883a9d00591e2470617da955..1956a185ef03bd52eb9af4fbcde203a6958a44c2 100644 (file)
--- a/lib/isc/netmgr/udp.c
+++ b/lib/isc/netmgr/udp.c
@@ -129,9 +129,10 @@ start_udp_child(isc_nm_t *mgr, isc_sockaddr_t *iface, isc_nmsocket_t *sock,
                csock->fd = isc__nm_udp_lb_socket(mgr,
                                                  iface->type.sa.sa_family);
        } else {
+               INSIST(fd >= 0);
                csock->fd = dup(fd);
        }
-       REQUIRE(csock->fd >= 0);
+       INSIST(csock->fd >= 0);
 
        ievent = isc__nm_get_netievent_udplisten(mgr, csock);
        isc__nm_maybe_enqueue_ievent(&mgr->workers[tid],