ruledb: drop the MDB_WRITEMAP flag

I like the property of mapping this memory as read-only.
All writes should have been deferred to the policy-loader,
at least in normal operation.

diff --git a/lib/cache/cdb_lmdb.c b/lib/cache/cdb_lmdb.c
index 624786054cb6e72e6a6525beb747443b705ea035..0319b5cbb3d9e2d84bae5843597a75f9e080ae9a 100644 (file)
--- a/lib/cache/cdb_lmdb.c
+++ b/lib/cache/cdb_lmdb.c
@@ -358,7 +358,10 @@ static int cdb_open_env(struct lmdb_env *env, const char *path, const size_t map
                /* Cache doesn't require durability, we can be
                 * loose with the requirements as a tradeoff for speed. */
                ? MDB_WRITEMAP | MDB_NOTLS | MDB_MAPASYNC
-               : MDB_WRITEMAP | MDB_NOTLS;
+               /* ruledb is quite different in terms of writes.
+                * MDB_WRITEMAP|MDB_MAPASYNC wouldn't benefit us much,
+                * so instead we get better protection + (integrity on crashes).*/
+               : MDB_NOTLS;
        ret = mdb_env_open(env->env, path, flags, LMDB_FILE_MODE);
        if (ret != MDB_SUCCESS) goto error_mdb;