]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
build: clang 21 re-enable -Wunititialized-const-pointer
authorGary Lockyer <gary@catalyst.net.nz>
Mon, 2 Mar 2026 00:32:23 +0000 (13:32 +1300)
committerAnoop C S <anoopcs@samba.org>
Tue, 3 Mar 2026 05:55:25 +0000 (05:55 +0000)
[4102/5009] Compiling source4/torture/rpc/spoolss_notify.c
  ../../source4/torture/rpc/spoolss.c:3984:48: error: variable 'data' is
       uninitialized when passed as a const pointer argument here
       [-Werror,-Wuninitialized-const-pointer]
    3984CHECK_NEEDED_SIZE_LEVEL(spoolss_PrinterData, &data, type, needed, 1);

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Tue Mar  3 05:55:25 UTC 2026 on atb-devel-224

buildtools/wafsamba/samba_autoconf.py
source4/torture/rpc/spoolss.c

index d79ca156d99b2a80cf9ed9864d8fcb07fadadcf0..b777391a03809bb7d7691965739dabc0abfe31e3 100644 (file)
@@ -843,7 +843,6 @@ int main(void) {
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Werror -Wno-error=deprecated-declarations', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=tautological-compare', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=cast-align', testflags=True)
-            conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=uninitialized-const-pointer', testflags=True)
 
     if Options.options.fatal_errors:
         conf.ADD_CFLAGS('-Wfatal-errors', testflags=True)
index e9aebcf5d03f2e253f42a54ad5c6c4e44235f73e..f8c71cb6db3a6ea4ced2dd060927d450cb5b3080 100644 (file)
@@ -3954,7 +3954,7 @@ static bool test_GetPrinterData_checktype(struct torture_context *tctx,
        struct spoolss_GetPrinterData r;
        uint32_t needed;
        enum winreg_Type type;
-       union spoolss_PrinterData data;
+       union spoolss_PrinterData data = {};
 
        r.in.handle = handle;
        r.in.value_name = value_name;
@@ -4024,7 +4024,7 @@ static bool test_GetPrinterDataEx_checktype(struct torture_context *tctx,
        struct spoolss_GetPrinterDataEx r;
        enum winreg_Type type;
        uint32_t needed;
-       union spoolss_PrinterData data;
+       union spoolss_PrinterData data = {};
        struct dcerpc_binding_handle *b = p->binding_handle;
 
        r.in.handle = handle;