[master] close() fd when done (Coverity report)

diff --git a/lib/isc/tests/file_test.c b/lib/isc/tests/file_test.c
index a6f55ef4556bc444a97f2873eeb600b8adab46ca..b252b50580ed47b0ab09b7d7bd89689033a20ea6 100644 (file)
--- a/lib/isc/tests/file_test.c
+++ b/lib/isc/tests/file_test.c
@@ -46,6 +46,7 @@ ATF_TC_HEAD(isc_file_sanitize, tc) {
 ATF_TC_BODY(isc_file_sanitize, tc) {
        isc_result_t result;
        char buf[1024];
+       int fd;
 
        ATF_CHECK(chdir(TESTS) != -1);
 
@@ -56,15 +57,19 @@ ATF_TC_BODY(isc_file_sanitize, tc) {
        ATF_CHECK_EQ(result, ISC_R_SUCCESS);
        ATF_CHECK(strcmp(buf, F(NAME)) == 0);
 
-       ATF_CHECK(creat(F(TRUNC_SHA), 0644) != -1);
+       fd = creat(F(TRUNC_SHA), 0644);
+       ATF_CHECK(fd != -1);
        result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024);
        ATF_CHECK_EQ(result, ISC_R_SUCCESS);
        ATF_CHECK(strcmp(buf, F(TRUNC_SHA)) == 0);
+       close(fd);
 
-       ATF_CHECK(creat(F(SHA), 0644) != -1);
+       fd = creat(F(SHA), 0644);
+       ATF_CHECK(fd != -1);
        result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024);
        ATF_CHECK_EQ(result, ISC_R_SUCCESS);
        ATF_CHECK(strcmp(buf, F(SHA)) == 0);
+       close(fd);
 
        result = isc_file_sanitize("testdata/file", BAD1, "test", buf, 1024);
        ATF_CHECK_EQ(result, ISC_R_SUCCESS);