]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3/rpc_client: lookupsids error handling of NT_STATUS_NONE_MAPPED
authorRalph Boehme <slow@samba.org>
Sat, 1 Apr 2017 14:51:07 +0000 (16:51 +0200)
committerKarolin Seeger <kseeger@samba.org>
Thu, 20 Apr 2017 10:23:18 +0000 (12:23 +0200)
NT_STATUS_NONE_MAPPED is not a fatal error, it just means we must return
all lsa_TranslatedName's as type SID_NAME_UNKNOWN.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=12728

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 416c74e8c89dc2fb2083beaaa9ac8a6e975ec873)

source3/rpc_client/cli_lsarpc.c

index cfa1f4affcbbcd99902c7085ba7de875d434b65f..fdfae30a9ea2bdff5fae4d3c325c9c047c637583 100644 (file)
@@ -28,6 +28,7 @@
 #include "rpc_client/cli_lsarpc.h"
 #include "rpc_client/init_lsa.h"
 #include "../libcli/security/security.h"
+#include "lsa.h"
 
 /** @defgroup lsa LSA - Local Security Architecture
  *  @ingroup rpc_client
@@ -221,7 +222,7 @@ static NTSTATUS dcerpc_lsa_lookup_sids_noalloc(struct dcerpc_binding_handle *h,
                        return status;
                }
 
-               if(!NT_STATUS_IS_ERR(result)) {
+               if (!NT_STATUS_LOOKUP_ERR(result)) {
                        lsa_names.count = lsa_names2.count;
                        lsa_names.names = talloc_array(mem_ctx,
                                                       struct lsa_TranslatedName,