]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()
authorFelix Gu <ustc.gu@gmail.com>
Wed, 25 Mar 2026 16:23:58 +0000 (00:23 +0800)
committerVinod Koul <vkoul@kernel.org>
Sun, 10 May 2026 12:04:18 +0000 (17:34 +0530)
When clk_enable() fails, the clock was never enabled. Calling
clk_disable() in this error path is incorrect.

Remove the spurious clk_disable() call from the error handling
in spacemit_usb2phy_init().

Fixes: fe4bc1a08638 ("phy: spacemit: support K1 USB2.0 PHY controller")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Ze Huang <huang.ze@linux.dev>
Link: https://patch.msgid.link/20260326-k1-usb3-v1-1-0c2b6adf5185@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/spacemit/phy-k1-usb2.c

index 9215d0b223b2d697327388f044448eb61c5306d8..e8c1e26428a910ea9847cc35f711883b97c5392c 100644 (file)
@@ -97,7 +97,6 @@ static int spacemit_usb2phy_init(struct phy *phy)
        ret = clk_enable(sphy->clk);
        if (ret) {
                dev_err(&phy->dev, "failed to enable clock\n");
-               clk_disable(sphy->clk);
                return ret;
        }