]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
fbdev: clps711x-fb: Request memory region for MMIO
authorAmit Barzilai <amit.barzilai22@gmail.com>
Mon, 20 Apr 2026 13:44:23 +0000 (16:44 +0300)
committerHelge Deller <deller@gmx.de>
Wed, 22 Apr 2026 14:46:40 +0000 (16:46 +0200)
Use devm_platform_get_and_ioremap_resource() for resource 0 (the MMIO
control register range) instead of open-coding platform_get_resource()
and devm_ioremap() separately. The helper requests the memory region
before mapping it, which registers the range in /proc/iomem and prevents
another driver from mapping the same registers.

This makes resource 0 consistent with resource 1 (the framebuffer),
which already uses devm_platform_get_and_ioremap_resource().

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Amit Barzilai <amit.barzilai22@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/clps711x-fb.c

index 5e61a349a4ab61a0fa61255b3f07f49dbb3f8865..7a7db7100499edcb42fbcab965b54cf6c7dafac0 100644 (file)
@@ -216,12 +216,9 @@ static int clps711x_fb_probe(struct platform_device *pdev)
        cfb = info->par;
        platform_set_drvdata(pdev, info);
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res)
-               goto out_fb_release;
-       cfb->base = devm_ioremap(dev, res->start, resource_size(res));
-       if (!cfb->base) {
-               ret = -ENOMEM;
+       cfb->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
+       if (IS_ERR(cfb->base)) {
+               ret = PTR_ERR(cfb->base);
                goto out_fb_release;
        }