]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe: Define and use MCR version of COMMON_SLICE_CHICKEN1
authorGustavo Sousa <gustavo.sousa@intel.com>
Thu, 14 May 2026 21:44:45 +0000 (18:44 -0300)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 18 May 2026 13:22:41 +0000 (09:22 -0400)
The register COMMON_SLICE_CHICKEN1 is a MCR register on Xe2.
Let's make sure to define a MCR version of it and use it for the
relevant IP versions.

Use XEHP_ as prefix for the register name, since it is MCR as of Xe_HP.

Fixes: a5d221924e13 ("drm/xe/xe2_hpg: Add set of workarounds")
Fixes: 9f18b55b6d3f ("drm/xe/xe2: Add workaround 18033852989")
Bspec: 66534, 71185
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patch.msgid.link/20260514-rtp-mcr-check-v3-2-30dd47855fee@intel.com
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
(cherry picked from commit a672725fdbfc3ea430130039d677c7dc98d59df8)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/regs/xe_gt_regs.h
drivers/gpu/drm/xe/xe_wa.c

index 4399518c270ec10cdb89717d402c50aa991194ae..ed9aba5bf75e357889e2e0be8fa768a58ae61d72 100644 (file)
 #define   MSAA_OPTIMIZATION_REDUC_DISABLE      REG_BIT(11)
 
 #define COMMON_SLICE_CHICKEN1                  XE_REG(0x7010, XE_REG_OPTION_MASKED)
+#define XEHP_COMMON_SLICE_CHICKEN1             XE_REG_MCR(0x7010, XE_REG_OPTION_MASKED)
 #define   DISABLE_BOTTOM_CLIP_RECTANGLE_TEST   REG_BIT(14)
 
 #define HIZ_CHICKEN                                    XE_REG(0x7018, XE_REG_OPTION_MASKED)
index 4b1cbced06bec224558fcc126e8df27e4cf4e0d2..100569a62283b524f77807ab3c10329a46979615 100644 (file)
@@ -651,7 +651,7 @@ static const struct xe_rtp_entry_sr lrc_was[] = {
        },
        { XE_RTP_NAME("18033852989"),
          XE_RTP_RULES(GRAPHICS_VERSION_RANGE(2001, 2004), ENGINE_CLASS(RENDER)),
-         XE_RTP_ACTIONS(SET(COMMON_SLICE_CHICKEN1, DISABLE_BOTTOM_CLIP_RECTANGLE_TEST))
+         XE_RTP_ACTIONS(SET(XEHP_COMMON_SLICE_CHICKEN1, DISABLE_BOTTOM_CLIP_RECTANGLE_TEST))
        },
        { XE_RTP_NAME("15016589081"),
          XE_RTP_RULES(GRAPHICS_VERSION_RANGE(2001, 2004), ENGINE_CLASS(RENDER)),