]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
bhyve: improve ISA controller validation error reporting
authorRoman Bogorodskiy <bogorodskiy@gmail.com>
Tue, 21 Apr 2026 18:21:31 +0000 (20:21 +0200)
committerRoman Bogorodskiy <bogorodskiy@gmail.com>
Sat, 2 May 2026 08:31:55 +0000 (10:31 +0200)
Report error in case when incorrect index is specified for
the ISA controller.

Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/bhyve/bhyve_domain.c

index 484f7b9d6e45cb0ffe3de0903c06d0475a26b4fd..832a9b58d1f3ae7cf9fc99983701c147fb884dc8 100644 (file)
@@ -323,6 +323,8 @@ bhyveDomainDeviceDefValidate(const virDomainDeviceDef *dev,
 
         if (controller->type == VIR_DOMAIN_CONTROLLER_TYPE_ISA &&
             controller->idx != 0) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                           _("Bhyve ISA controller can only have index '0'"));
             return -1;
         } else if (controller->type == VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL) {
             if (controller->opts.vioserial.ports > 16) {