]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: attach/detach device: Move 'virCheckFlags' to top level functions
authorPeter Krempa <pkrempa@redhat.com>
Thu, 2 Apr 2026 13:41:24 +0000 (15:41 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 14 May 2026 10:13:09 +0000 (12:13 +0200)
Move the flag check to the top level to allow programatic introspection
of supported flags.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c

index f29211e4224a833a78acd4f735151a3b47db5982..38705ef161e5fa026dd93a30f9883728a498dcd0 100644 (file)
@@ -7423,9 +7423,6 @@ qemuDomainAttachDeviceLiveAndConfig(virDomainObj *vm,
     unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE |
                                VIR_DOMAIN_DEF_PARSE_ABI_UPDATE;
 
-    virCheckFlags(VIR_DOMAIN_AFFECT_LIVE |
-                  VIR_DOMAIN_AFFECT_CONFIG, -1);
-
     cfg = virQEMUDriverGetConfig(driver);
 
     /* The config and live post processing address auto-generation algorithms
@@ -7518,6 +7515,9 @@ qemuDomainAttachDeviceFlags(virDomainPtr dom,
     virDomainObj *vm = NULL;
     int ret = -1;
 
+    virCheckFlags(VIR_DOMAIN_AFFECT_LIVE |
+                  VIR_DOMAIN_AFFECT_CONFIG, -1);
+
     if (!(vm = qemuDomainObjFromDomain(dom)))
         goto cleanup;
 
@@ -7666,9 +7666,6 @@ qemuDomainDetachDeviceLiveAndConfig(virQEMUDriver *driver,
     unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE;
     g_autoptr(virDomainDef) vmdef = NULL;
 
-    virCheckFlags(VIR_DOMAIN_AFFECT_LIVE |
-                  VIR_DOMAIN_AFFECT_CONFIG, -1);
-
     cfg = virQEMUDriverGetConfig(driver);
 
     if ((flags & VIR_DOMAIN_AFFECT_CONFIG) &&
@@ -7802,6 +7799,9 @@ qemuDomainDetachDeviceFlags(virDomainPtr dom,
     virDomainObj *vm = NULL;
     int ret = -1;
 
+    virCheckFlags(VIR_DOMAIN_AFFECT_LIVE |
+                  VIR_DOMAIN_AFFECT_CONFIG, -1);
+
     if (!(vm = qemuDomainObjFromDomain(dom)))
         goto cleanup;