scsi: fnic: Do not use GFP_ZERO for mempools

One cannot use the GFP_ZERO flag for mempool allocation, so use
memset() instead.

Tested-by: Karan Tilak Kumar <kartilak@cisco.com>
Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: Arun Easi <aeasi@cisco.com>
Reviewed-by: Hannes Reinecke <hare@kernel.org>
Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
Co-developed-by: Hannes Reinecke <hare@kernel.org>
Link: https://patch.msgid.link/20260217223943.7938-2-kartilak@cisco.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
index f6d6ad64983f8d483f890fdb34c1f271a03d69c9..2b543d5700510376397650ced95fe2b196fe424d 100644 (file)
--- a/drivers/scsi/fnic/fnic_fcs.c
+++ b/drivers/scsi/fnic/fnic_fcs.c
@@ -519,13 +519,13 @@ static void fnic_rq_cmpl_frame_recv(struct vnic_rq *rq, struct cq_desc
 
        spin_unlock_irqrestore(&fnic->fnic_lock, flags);
 
-       frame_elem = mempool_alloc(fnic->frame_elem_pool,
-                                       GFP_ATOMIC | __GFP_ZERO);
+       frame_elem = mempool_alloc(fnic->frame_elem_pool, GFP_ATOMIC);
        if (!frame_elem) {
                FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
                                 "Failed to allocate memory for frame elem");
                goto drop;
        }
+       memset(frame_elem, 0, sizeof(struct fnic_frame_list));
        frame_elem->fp = fp;
        frame_elem->rx_ethhdr_stripped = ethhdr_stripped;
        frame_elem->frame_len = bytes_written;
@@ -704,13 +704,13 @@ fdls_send_fcoe_frame(struct fnic *fnic, void *frame, int frame_size,
         */
        if ((fnic->state != FNIC_IN_FC_MODE)
                && (fnic->state != FNIC_IN_ETH_MODE)) {
-               frame_elem = mempool_alloc(fnic->frame_elem_pool,
-                                               GFP_ATOMIC | __GFP_ZERO);
+               frame_elem = mempool_alloc(fnic->frame_elem_pool, GFP_ATOMIC);
                if (!frame_elem) {
                        FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
                                 "Failed to allocate memory for frame elem");
                        return -ENOMEM;
                }
+               memset(frame_elem, 0, sizeof(struct fnic_frame_list));
 
                FNIC_FCS_DBG(KERN_DEBUG, fnic->host, fnic->fnic_num,
                        "Queueing FC frame: sid/did/type/oxid = 0x%x/0x%x/0x%x/0x%x\n",