]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix logging a uint32_t SOA serial value in dns_catz_update_from_db()
authorAram Sargsyan <aram@isc.org>
Wed, 14 Dec 2022 14:40:31 +0000 (14:40 +0000)
committerAram Sargsyan <aram@isc.org>
Thu, 15 Dec 2022 13:49:58 +0000 (13:49 +0000)
The dns_catz_update_from_db() function prints serial number as a signed
number (with "%d" in the format string), but the `vers` variable's type
is 'uint32_t'. This breaks serials bigger than 2^31.

Use PRIu32 instead of "d" in the format string.

(cherry picked from commit 72b1760ea6cd415efe9868aad97c982fea8b0a42)

lib/dns/catz.c

index 49ad9bf37bfd1ad02eaafd94d181c645bdc798a6..8a552d12595ca501f1c5a4c2a811f34b18479aa0 100644 (file)
@@ -1874,8 +1874,8 @@ dns_catz_update_from_db(dns_db_t *db, dns_catz_zones_t *catzs) {
 
        isc_log_write(dns_lctx, DNS_LOGCATEGORY_GENERAL, DNS_LOGMODULE_MASTER,
                      ISC_LOG_INFO,
-                     "catz: updating catalog zone '%s' with serial %d", bname,
-                     vers);
+                     "catz: updating catalog zone '%s' with serial %" PRIu32,
+                     bname, vers);
 
        result = dns_catz_new_zone(catzs, &newzone, &db->origin);
        if (result != ISC_R_SUCCESS) {