git-gui: remove unnecessary 'cd $_gitworktree' from do_gitk

In the procedure that invokes Gitk, we have a 'cd $_gitworktree'. Such
a change of the current directory is not necessary, because

- if we have a working tree, then the startup routine has already
  changed the current directory to the root of the working tree, which
  *is* $_gitworktree; or

- if we are in a bare repository, then there is no point in changing
  the current directory anywhere. (And $_gitworktree is empty.)

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>

diff --git a/git-gui.sh b/git-gui.sh
index f70a54a61b26647da10efcdaddfcc1d73e0d6c8e..52897fbd0998184a1578ccf3c854c504fb7b6984 100755 (executable)
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -2024,11 +2024,7 @@ proc do_gitk {revs {is_submodule false}} {
 
                set pwd [pwd]
 
-               if {!$is_submodule} {
-                       if {![is_bare]} {
-                               cd $_gitworktree
-                       }
-               } else {
+               if {$is_submodule} {
                        cd $current_diff_path
                        if {$revs eq {--}} {
                                set s $file_states($current_diff_path)