hwmon: (gpd-fan): Initialize EC before registering hwmon device

Move the gpd_init_ec() call to before devm_hwmon_device_register_with_info
in the probe function. With the previous ordering the hwmon device was
registered and exposed to userspace before the EC initialization
completes, creating a window where sysfs reads could return invalid values.

Some buggy firmware won't initialize EC properly on boot. Before its
initialization, reading RPM will always return 0, and writing PWM will have
no effect. So move gpd_init_ec to before hwmon device register.

Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Link: https://lore.kernel.org/r/4be3734b135c8013157979ab5e80c7ee51243ddd.1781055639.git.xiaopei01@kylinos.cn
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
index 7284babd4f5c96e6cd0a50a710cdc3f7019047b9..745b3fb9e3a49df96ebe59a65354f674deb21748 100644 (file)
--- a/drivers/hwmon/gpd-fan.c
+++ b/drivers/hwmon/gpd-fan.c
@@ -643,6 +643,7 @@ static int gpd_fan_probe(struct platform_device *pdev)
 
        dev_set_drvdata(dev, data);
 
+       gpd_init_ec(data);
        hwdev = devm_hwmon_device_register_with_info(dev,
                                                     DRIVER_NAME,
                                                     data,
@@ -651,9 +652,6 @@ static int gpd_fan_probe(struct platform_device *pdev)
        if (IS_ERR(hwdev))
                return dev_err_probe(dev, PTR_ERR(hwdev),
                                     "Failed to register hwmon device\n");
-
-       gpd_init_ec(data);
-
        return 0;
 }