]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
octeontx2-pf: Fix NDC sync operation errors
authorGeetha sowjanya <gakula@marvell.com>
Fri, 29 May 2026 11:37:57 +0000 (17:07 +0530)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Jun 2026 01:11:08 +0000 (18:11 -0700)
On system reboot "rvu_nicpf 0002:03:00.0: NDC sync operation failed"
error messages are shown, even if the operations is successful.
This is due to wrong if error check in ndc_syc() function.

Fixes: 42c45ac1419c ("octeontx2-af: Sync NIX and NPA contexts from NDC to LLC/DRAM")
Signed-off-by: Geetha sowjanya <gakula@marvell.com>
Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/1780054677-17249-1-git-send-email-sbhatta@marvell.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c

index ee623476e5ff1ad10a4149a065773fcd7050d970..f9fbf0c176482536a43bb1d865360255dc48ab5f 100644 (file)
@@ -3473,7 +3473,7 @@ static void otx2_ndc_sync(struct otx2_nic *pf)
        req->nix_lf_rx_sync = 1;
        req->npa_lf_sync = 1;
 
-       if (!otx2_sync_mbox_msg(mbox))
+       if (otx2_sync_mbox_msg(mbox))
                dev_err(pf->dev, "NDC sync operation failed\n");
 
        mutex_unlock(&mbox->lock);