Great badness - not a good idea to return OK when you don't modify the

  resulting value, even if it's NULL.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91345 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/server/config.c b/server/config.c
index 4258f31bcd07af6d59dfd9deb79d468671b9c837..291d129ee07a82205611f471861eec1cd6d39fef 100644 (file)
--- a/server/config.c
+++ b/server/config.c
@@ -1475,9 +1475,8 @@ AP_CORE_DECLARE(int) ap_parse_htaccess(ap_conf_vector_t **result,
     /* firstly, search cache */
     for (cache = r->htaccess; cache != NULL; cache = cache->next)
        if (cache->override == override && strcmp(cache->dir, d) == 0) {
-           if (cache->htaccess != NULL)
-               *result = cache->htaccess;
-           return OK;
+           *result = cache->htaccess;
+            return OK;
        }
 
     parms = default_parms;