]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
named: Add INSIST() after bindkeysfile configuration load to silence scan-build FP
authorOndřej Surý <ondrej@sury.org>
Sun, 13 Oct 2019 04:47:26 +0000 (06:47 +0200)
committerOndřej Surý <ondrej@sury.org>
Tue, 5 Nov 2019 08:48:50 +0000 (09:48 +0100)
(cherry picked from commit 6bf364aec87773764c2850a95251aa6a15cf320e)

bin/named/server.c

index 148edb5bfc9b190a47f86a3e360cb2a85d675966..5c72e36e9cebfa35c4d4dd879d9dc56c485a2ee1 100644 (file)
@@ -8202,6 +8202,7 @@ load_configuration(const char *filename, named_server_t *server,
        INSIST(result == ISC_R_SUCCESS);
        CHECKM(setstring(server, &server->bindkeysfile,
               cfg_obj_asstring(obj)), "strdup");
+       INSIST(server->bindkeysfile != NULL);
 
        if (access(server->bindkeysfile, R_OK) == 0) {
                isc_log_write(named_g_lctx, NAMED_LOGCATEGORY_GENERAL,