]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ALSA: usb-audio: qcom: Improve error logging in USB offload
authorwangdicheng <wangdicheng@kylinos.cn>
Wed, 3 Jun 2026 09:10:59 +0000 (17:10 +0800)
committerTakashi Iwai <tiwai@suse.de>
Thu, 4 Jun 2026 08:15:09 +0000 (10:15 +0200)
Add error codes to error messages for better debugging.
This helps identify the root cause when USB audio offload fails.

Error messages now include the actual error code returned by
xhci_sideband operations, making it easier to diagnose failures
during USB audio offload setup.

Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20260603091102.231370-1-wangdich9700@163.com
sound/usb/qcom/qc_audio_offload.c

index a0009503b2c59246bbce1e4f07eb6a803537b565..f99f8bddb2379545b1dcc32caa71c6d94062efea 100644 (file)
@@ -1140,7 +1140,7 @@ uaudio_endpoint_setup(struct snd_usb_substream *subs,
        ret = xhci_sideband_add_endpoint(uadev[card_num].sb, ep);
        if (ret < 0) {
                dev_err(&subs->dev->dev,
-                       "failed to add data ep to sec intr\n");
+                       "failed to add data ep to sec intr: %d\n", ret);
                ret = -ENODEV;
                goto exit;
        }
@@ -1148,7 +1148,7 @@ uaudio_endpoint_setup(struct snd_usb_substream *subs,
        sgt = xhci_sideband_get_endpoint_buffer(uadev[card_num].sb, ep);
        if (!sgt) {
                dev_err(&subs->dev->dev,
-                       "failed to get data ep ring address\n");
+                       "failed to get data ep ring address: %d\n", ret);
                ret = -ENODEV;
                goto remove_ep;
        }