]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
soc: fsl: cpm1: qmc: Fix error check for devm_ioremap_resource() in qmc_qe_init_resou...
authorChen Ni <nichen@iscas.ac.cn>
Mon, 9 Feb 2026 01:59:04 +0000 (09:59 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Mar 2026 10:08:51 +0000 (11:08 +0100)
[ Upstream commit 3f4e403304186d79fddace860360540fc3af97f9 ]

Fix wrong variable used for error checking after devm_ioremap_resource()
call. The function checks qmc->scc_pram instead of qmc->dpram, which
could lead to incorrect error handling.

Fixes: eb680d563089 ("soc: fsl: cpm1: qmc: Add support for QUICC Engine (QE) implementation")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Acked-by: Herve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20260209015904.871269-1-nichen@iscas.ac.cn
Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/fsl/qe/qmc.c

index 36c0ccc06151f3343d97266a6c0e13ba9f59fb39..cc7032a0ad8c3a4053692ad7dfeb9f20b5826992 100644 (file)
@@ -1777,8 +1777,8 @@ static int qmc_qe_init_resources(struct qmc *qmc, struct platform_device *pdev)
                return -EINVAL;
        qmc->dpram_offset = res->start - qe_muram_dma(qe_muram_addr(0));
        qmc->dpram = devm_ioremap_resource(qmc->dev, res);
-       if (IS_ERR(qmc->scc_pram))
-               return PTR_ERR(qmc->scc_pram);
+       if (IS_ERR(qmc->dpram))
+               return PTR_ERR(qmc->dpram);
 
        return 0;
 }