usb: core: Clean up SuperSpeed/eUSB2 descriptor validation logging

Core usually prints endpoint addresses with 0x%X format.
Change this code to use it too, instead of just %d.
Particularly for IN, 0x83 seems more readable than 131.

While at that, fix checkpatch warnings about multi-line
quoted strings, as well as missing or doubled whitespace
in those strings.

Signed-off-by: Michal Pecio <michal.pecio@gmail.com>
Link: https://patch.msgid.link/20260518073258.6532bdd5.michal.pecio@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index d9171bf7bc883f7923e6165e93794a5782538051..45e20c6d76c04c6ecd9eb366b3f4326d2d777e85 100644 (file)
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -56,8 +56,7 @@ static void usb_parse_ssp_isoc_endpoint_companion(struct device *ddev,
        desc = (struct usb_ssp_isoc_ep_comp_descriptor *) buffer;
        if (size < USB_DT_SSP_ISOC_EP_COMP_SIZE ||
            desc->bDescriptorType != USB_DT_SSP_ISOC_ENDPOINT_COMP) {
-               dev_notice(ddev, "Invalid SuperSpeedPlus isoc endpoint companion"
-                        "for config %d interface %d altsetting %d ep %d.\n",
+               dev_notice(ddev, "Invalid SuperSpeedPlus isoc endpoint companion for config %d interface %d altsetting %d ep 0x%X.\n",
                         cfgno, inum, asnum, ep->desc.bEndpointAddress);
                return;
        }
@@ -91,7 +90,7 @@ static void usb_parse_eusb2_isoc_endpoint_companion(struct device *ddev,
                size -= h->bLength;
        }
 
-       dev_notice(ddev, "No eUSB2 isoc ep %d companion for config %d interface %d altsetting %d\n",
+       dev_notice(ddev, "No eUSB2 isoc ep 0x%X companion for config %d interface %d altsetting %d\n",
                   ep->desc.bEndpointAddress, cfgno, inum, asnum);
 }
 
@@ -115,9 +114,7 @@ static void usb_parse_ss_endpoint_companion(struct device *ddev, int cfgno,
        }
 
        if (desc->bDescriptorType != USB_DT_SS_ENDPOINT_COMP) {
-               dev_notice(ddev, "No SuperSpeed endpoint companion for config %d "
-                               " interface %d altsetting %d ep %d: "
-                               "using minimum values\n",
+               dev_notice(ddev, "No SuperSpeed endpoint companion for config %d interface %d altsetting %d ep 0x%X: using minimum values\n",
                                cfgno, inum, asnum, ep->desc.bEndpointAddress);
 
                /* Fill in some default values.
@@ -141,42 +138,32 @@ static void usb_parse_ss_endpoint_companion(struct device *ddev, int cfgno,
 
        /* Check the various values */
        if (usb_endpoint_xfer_control(&ep->desc) && desc->bMaxBurst != 0) {
-               dev_notice(ddev, "Control endpoint with bMaxBurst = %d in "
-                               "config %d interface %d altsetting %d ep %d: "
-                               "setting to zero\n", desc->bMaxBurst,
-                               cfgno, inum, asnum, ep->desc.bEndpointAddress);
+               dev_notice(ddev, "Control endpoint with bMaxBurst = %d in config %d interface %d altsetting %d ep 0x%X: setting to zero\n",
+                               desc->bMaxBurst, cfgno, inum, asnum, ep->desc.bEndpointAddress);
                ep->ss_ep_comp.bMaxBurst = 0;
        } else if (desc->bMaxBurst > 15) {
-               dev_notice(ddev, "Endpoint with bMaxBurst = %d in "
-                               "config %d interface %d altsetting %d ep %d: "
-                               "setting to 15\n", desc->bMaxBurst,
-                               cfgno, inum, asnum, ep->desc.bEndpointAddress);
+               dev_notice(ddev, "Endpoint with bMaxBurst = %d in config %d interface %d altsetting %d ep 0x%X: setting to 15\n",
+                               desc->bMaxBurst, cfgno, inum, asnum, ep->desc.bEndpointAddress);
                ep->ss_ep_comp.bMaxBurst = 15;
        }
 
        if ((usb_endpoint_xfer_control(&ep->desc) ||
                        usb_endpoint_xfer_int(&ep->desc)) &&
                                desc->bmAttributes != 0) {
-               dev_notice(ddev, "%s endpoint with bmAttributes = %d in "
-                               "config %d interface %d altsetting %d ep %d: "
-                               "setting to zero\n",
+               dev_notice(ddev, "%s endpoint with bmAttributes = %d in config %d interface %d altsetting %d ep 0x%X: setting to zero\n",
                                usb_endpoint_xfer_control(&ep->desc) ? "Control" : "Bulk",
                                desc->bmAttributes,
                                cfgno, inum, asnum, ep->desc.bEndpointAddress);
                ep->ss_ep_comp.bmAttributes = 0;
        } else if (usb_endpoint_xfer_bulk(&ep->desc) &&
                        desc->bmAttributes > 16) {
-               dev_notice(ddev, "Bulk endpoint with more than 65536 streams in "
-                               "config %d interface %d altsetting %d ep %d: "
-                               "setting to max\n",
+               dev_notice(ddev, "Bulk endpoint with more than 65536 streams in config %d interface %d altsetting %d ep 0x%X: setting to max\n",
                                cfgno, inum, asnum, ep->desc.bEndpointAddress);
                ep->ss_ep_comp.bmAttributes = 16;
        } else if (usb_endpoint_xfer_isoc(&ep->desc) &&
                   !USB_SS_SSP_ISOC_COMP(desc->bmAttributes) &&
                   USB_SS_MULT(desc->bmAttributes) > 3) {
-               dev_notice(ddev, "Isoc endpoint has Mult of %d in "
-                               "config %d interface %d altsetting %d ep %d: "
-                               "setting to 3\n",
+               dev_notice(ddev, "Isoc endpoint has Mult of %d in config %d interface %d altsetting %d ep 0x%X: setting to 3\n",
                                USB_SS_MULT(desc->bmAttributes),
                                cfgno, inum, asnum, ep->desc.bEndpointAddress);
                ep->ss_ep_comp.bmAttributes = 2;
@@ -199,9 +186,7 @@ static void usb_parse_ss_endpoint_companion(struct device *ddev, int cfgno,
        if (le16_to_cpu(desc->wBytesPerInterval) > max_tx ||
            (le16_to_cpu(desc->wBytesPerInterval) < usb_endpoint_maxp(&ep->desc) &&
             usb_endpoint_is_int_in(&ep->desc))) {
-               dev_notice(ddev, "%s endpoint with wBytesPerInterval of %d in "
-                               "config %d interface %d altsetting %d ep %d: "
-                               "setting to %d\n",
+               dev_notice(ddev, "%s endpoint with wBytesPerInterval of %d in config %d interface %d altsetting %d ep 0x%X: setting to %d\n",
                                usb_endpoint_xfer_isoc(&ep->desc) ? "Isoc" : "Int",
                                le16_to_cpu(desc->wBytesPerInterval),
                                cfgno, inum, asnum, ep->desc.bEndpointAddress,