2467. [bug] Failure of fcntl(F_DUPFD) wasn't logged. [RT #18740]

diff --git a/CHANGES b/CHANGES
index 88a41150159f0c203889c24eacb2719febd3c8a6..9a89655405ffae402d7e63e80b4633a807d4c21d 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,5 @@
+2467.  [bug]           Failure of fcntl(F_DUPFD) wasn't logged. [RT #18740]
+
 2466.  [doc]           ARM: explain max-cache-ttl 0 SERVFAIL issue.
                        [RT #18302]
 

diff --git a/lib/isc/unix/socket.c b/lib/isc/unix/socket.c
index 531bac1a4678b77b1cc4a77642a4ff75f6256a5b..67f34c8d3138eaf31a775985dc9c5ce479e54323 100644 (file)
--- a/lib/isc/unix/socket.c
+++ b/lib/isc/unix/socket.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: socket.c,v 1.303 2008/09/23 02:20:21 marka Exp $ */
+/* $Id: socket.c,v 1.304 2008/10/17 21:49:23 jinmei Exp $ */
 
 /*! \file */
 
@@ -1894,6 +1894,13 @@ opensocket(isc_socketmgr_t *manager, isc_socket_t *sock) {
                switch (errno) {
                case EMFILE:
                case ENFILE:
+                       isc__strerror(errno, strbuf, sizeof(strbuf));
+                       isc_log_iwrite(isc_lctx, ISC_LOGCATEGORY_GENERAL,
+                                      ISC_LOGMODULE_SOCKET, ISC_LOG_ERROR,
+                                      isc_msgcat, ISC_MSGSET_SOCKET,
+                                      ISC_MSG_TOOMANYFDS,
+                                      "%s: %s", err, strbuf);
+                       /* fallthrough */
                case ENOBUFS:
                        return (ISC_R_NORESOURCES);