return failure on error

diff --git a/src/lib/server/virtual_servers.c b/src/lib/server/virtual_servers.c
index 5495835bb8ff5ff6b9283d12c1cfeb6c1a044148..c8b8a527d9bd105461ef0ea0770d1f4d9e3bcb15 100644 (file)
--- a/src/lib/server/virtual_servers.c
+++ b/src/lib/server/virtual_servers.c
@@ -1063,7 +1063,7 @@ int virtual_server_cf_parse(UNUSED TALLOC_CTX *ctx, void *out, UNUSED void *pare
 
                        if (!fr_cond_assert_msg(required_dict != NULL,
                                                "dict not resolved before virtual server reference")) {
-                               goto done;
+                               return -1;
                        }
 
                        if (required_dict != *vs->process_module->dict) {
@@ -1077,7 +1077,6 @@ int virtual_server_cf_parse(UNUSED TALLOC_CTX *ctx, void *out, UNUSED void *pare
                }
        }
 
-done:
        *((virtual_server_t const **)out) = vs;
 
        return 0;