]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
fbdev: vesafb: fix memory leak in vesafb_probe()
authorAbdun Nihaal <nihaal@cse.iitm.ac.in>
Thu, 14 May 2026 08:24:42 +0000 (13:54 +0530)
committerHelge Deller <deller@gmx.de>
Sun, 7 Jun 2026 16:25:42 +0000 (18:25 +0200)
Since commit 73ce73c30ba9 ("fbdev: Transfer video= option strings to
caller; clarify ownership") the string returned from fb_get_options()
is expected to be freed by the caller. But the string is not freed in
vesafb_probe(). Fix that by freeing the option string after setup.

Fixes: 73ce73c30ba9 ("fbdev: Transfer video= option strings to caller; clarify ownership")
Cc: stable@vger.kernel.org
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/vesafb.c

index f84f4db244bfe628c665324a15602e58fc3de8ea..f1902056bd7331923b64cf43899fdf90c5e16038 100644 (file)
@@ -269,6 +269,7 @@ static int vesafb_probe(struct platform_device *dev)
        /* ignore error return of fb_get_options */
        fb_get_options("vesafb", &option);
        vesafb_setup(option);
+       kfree(option);
 
        if (si->orig_video_isVGA != VIDEO_TYPE_VLFB)
                return -ENODEV;