2757. [bug] dig: assertion failure could occur in connect

			timeout. [RT #20599]

diff --git a/CHANGES b/CHANGES
index 41212ae68673935fec88b24bbe3ac2f5d732cedf..653a6a18133db31874e70e7cfe98f074802f7506 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+2757.  [bug]           dig: assertion failure could occur in connect
+                       timeout. [RT #20599]
+
 2755.  [doc]           Clarify documentation of keyset- files in
                        dnssec-signzone man page. [RT #19810]
 

diff --git a/bin/dig/dighost.c b/bin/dig/dighost.c
index 1d448ed2261892006d1a083a76e3ed4595a8d65c..65f3a23a8dbd23fcf811f82d2469c8b7a63e7b5c 100644 (file)
--- a/bin/dig/dighost.c
+++ b/bin/dig/dighost.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: dighost.c,v 1.304.12.17 2009/11/05 01:57:08 each Exp $ */
+/* $Id: dighost.c,v 1.304.12.18 2009/11/10 17:26:47 each Exp $ */
 
 /*! \file
  *  \note
@@ -2398,14 +2398,10 @@ connect_timeout(isc_task_t *task, isc_event_t *event) {
                cq = query->lookup->current_query;
                if (!l->tcp_mode)
                        send_udp(ISC_LIST_NEXT(cq, link));
-               else if (query->sock != NULL) {
-                       isc_socket_cancel(query->sock, NULL,
-                                         ISC_SOCKCANCEL_ALL);
-                       isc_socket_detach(&query->sock);
-                       sockcount--;
-                       debug("sockcount=%d", sockcount);
-                       send_tcp_connect(ISC_LIST_NEXT(cq, link));
-               } else {
+               else {
+                       if (query->sock != NULL)
+                               isc_socket_cancel(query->sock, NULL,
+                                                 ISC_SOCKCANCEL_ALL);
                        send_tcp_connect(ISC_LIST_NEXT(cq, link));
                }
                UNLOCK_LOOKUP;
@@ -2609,8 +2605,8 @@ connect_done(isc_task_t *task, isc_event_t *event) {
        if (sevent->result == ISC_R_CANCELED) {
                debug("in cancel handler");
                isc_socket_detach(&query->sock);
+               INSIST(sockcount > 0);
                sockcount--;
-               INSIST(sockcount >= 0);
                debug("sockcount=%d", sockcount);
                query->waiting_connect = ISC_FALSE;
                isc_event_free(&event);