source3/passdb: Add NULL check in pdb_samba_dsdb_update_sam_account()

pdb_samba_dsdb_get_samu_private() can return NULL on memory allocation or
database query failures. Add an explicit NULL check to prevent dereference
and return an error status early.

Signed-off-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

diff --git a/source3/passdb/pdb_samba_dsdb.c b/source3/passdb/pdb_samba_dsdb.c
index 96d9819316b9e28135edc6c3e4df948bedc34b9f..3d6de340b99dfa4699dbe60dd69cb07f7f2e6bcd 100644 (file)
--- a/source3/passdb/pdb_samba_dsdb.c
+++ b/source3/passdb/pdb_samba_dsdb.c
@@ -888,6 +888,10 @@ static NTSTATUS pdb_samba_dsdb_update_sam_account(struct pdb_methods *m,
                m, sam);
        int ret;
 
+       if (msg == NULL) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
        ret = pdb_samba_dsdb_replace_by_sam(state, pdb_element_is_changed, msg->dn,
                                        sam);
        return dsdb_ldb_err_to_ntstatus(ret);