]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix "array subscript is of type 'char'" on NetBSD 9
authorMichal Nowak <mnowak@isc.org>
Wed, 24 Nov 2021 15:50:57 +0000 (16:50 +0100)
committerMichal Nowak <mnowak@isc.org>
Thu, 25 Nov 2021 17:54:18 +0000 (18:54 +0100)
    In file included from rdata.c:602:
    In file included from ./code.h:88:
    ./rdata/in_1/svcb_64.c:259:9: warning: array subscript is of type 'char' [-Wchar-subscripts]
                            if (!isdigit(*region->base)) {
                                 ^~~~~~~~~~~~~~~~~~~~~~
    /usr/include/sys/ctype_inline.h:51:44: note: expanded from macro 'isdigit'
    #define isdigit(c)      ((int)((_ctype_tab_ + 1)[(c)] & _CTYPE_D))
                                                    ^~~~

(cherry picked from commit d09447287f02cdf479cf2e542e4ab0efe7a024fe)

lib/dns/rdata/in_1/svcb_64.c

index a28dfe20f543f8084f57e490ffb97aa20e34e3c9..44c2b69672a0ff18369d91284ee451de356f1764 100644 (file)
@@ -260,7 +260,7 @@ svc_fromtext(isc_textregion_t *region, isc_buffer_t *target) {
                        RETERR(alpn_fromtxt(region, target));
                        break;
                case sbpr_port:
-                       if (!isdigit(*region->base)) {
+                       if (!isdigit((unsigned char)*region->base)) {
                                return (DNS_R_SYNTAX);
                        }
                        ul = strtoul(region->base, &e, 10);