stdbit-h: fewer casts

* lib/stdbit.in.h (stdc_load8_beu16, stdc_load8_leu16)
(stdc_store8_beu16, stdc_store8_beu32, stdc_store8_beu64)
(stdc_store8_leu16, stdc_store8_leu32, stdc_store8_leu64):
Avoid unnecessary and sometimes-confusing casts.

diff --git a/ChangeLog b/ChangeLog
index 0ec1c253757fc23135712adab72ba69eac90c90b..8d1e8c2829779e1eee3c94a8eb8154ddbaff350c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2026-03-13  Paul Eggert  <eggert@cs.ucla.edu>
 
+       stdbit-h: fewer casts
+       * lib/stdbit.in.h (stdc_load8_beu16, stdc_load8_leu16)
+       (stdc_store8_beu16, stdc_store8_beu32, stdc_store8_beu64)
+       (stdc_store8_leu16, stdc_store8_leu32, stdc_store8_leu64):
+       Avoid unnecessary and sometimes-confusing casts.
+
        stdbit-h: simplify stdc_{load,store)_[bl]e[s]*
        * lib/stdbit.in.h (stdc_load8_bes8, stdc_load8_bes16)
        (stdc_load8_bes32, stdc_load8_bes64, stdc_load8_les8)

diff --git a/lib/stdbit.in.h b/lib/stdbit.in.h
index d2bf93677eda5c80b96468062cd117e1f8103c90..63c1db25ad88e2a9878e63746fae3ae3e62a00f6 100644 (file)
--- a/lib/stdbit.in.h
+++ b/lib/stdbit.in.h
@@ -1119,7 +1119,7 @@ stdc_load8_beu8 (const unsigned char ptr[1])
 _GL_STDC_LOAD8_INLINE uint_least16_t
 stdc_load8_beu16 (const unsigned char ptr[2])
 {
-  return ((uint_fast16_t) ptr[0] << 8) | (uint_fast16_t) ptr[1];
+  return (ptr[0] << 8) | ptr[1];
 }
 
 _GL_STDC_LOAD8_INLINE uint_least32_t
@@ -1147,7 +1147,7 @@ stdc_load8_leu8 (const unsigned char ptr[1])
 _GL_STDC_LOAD8_INLINE uint_least16_t
 stdc_load8_leu16 (const unsigned char ptr[2])
 {
-  return (uint_fast16_t) ptr[0] | ((uint_fast16_t) ptr[1] << 8);
+  return ptr[0] | (ptr[1] << 8);
 }
 
 _GL_STDC_LOAD8_INLINE uint_least32_t
@@ -1330,30 +1330,30 @@ stdc_store8_beu8 (uint_least8_t value, unsigned char ptr[1])
 _GL_STDC_STORE8_INLINE void
 stdc_store8_beu16 (uint_least16_t value, unsigned char ptr[2])
 {
-  ptr[0] = (unsigned char) (value >> 8) & 0xFFU;
-  ptr[1] = (unsigned char) value & 0xFFU;
+  ptr[0] = (value >> 8) & 0xFFU;
+  ptr[1] = value & 0xFFU;
 }
 
 _GL_STDC_STORE8_INLINE void
 stdc_store8_beu32 (uint_least32_t value, unsigned char ptr[4])
 {
-  ptr[0] = (unsigned char) (value >> 24) & 0xFFU;
-  ptr[1] = (unsigned char) (value >> 16) & 0xFFU;
-  ptr[2] = (unsigned char) (value >> 8) & 0xFFU;
-  ptr[3] = (unsigned char) value & 0xFFU;
+  ptr[0] = (value >> 24) & 0xFFU;
+  ptr[1] = (value >> 16) & 0xFFU;
+  ptr[2] = (value >> 8) & 0xFFU;
+  ptr[3] = value & 0xFFU;
 }
 
 _GL_STDC_STORE8_INLINE void
 stdc_store8_beu64 (uint_least64_t value, unsigned char ptr[8])
 {
-  ptr[0] = (unsigned char) (value >> 56) & 0xFFU;
-  ptr[1] = (unsigned char) (value >> 48) & 0xFFU;
-  ptr[2] = (unsigned char) (value >> 40) & 0xFFU;
-  ptr[3] = (unsigned char) (value >> 32) & 0xFFU;
-  ptr[4] = (unsigned char) (value >> 24) & 0xFFU;
-  ptr[5] = (unsigned char) (value >> 16) & 0xFFU;
-  ptr[6] = (unsigned char) (value >> 8) & 0xFFU;
-  ptr[7] = (unsigned char) value & 0xFFU;
+  ptr[0] = (value >> 56) & 0xFFU;
+  ptr[1] = (value >> 48) & 0xFFU;
+  ptr[2] = (value >> 40) & 0xFFU;
+  ptr[3] = (value >> 32) & 0xFFU;
+  ptr[4] = (value >> 24) & 0xFFU;
+  ptr[5] = (value >> 16) & 0xFFU;
+  ptr[6] = (value >> 8) & 0xFFU;
+  ptr[7] = value & 0xFFU;
 }
 
 _GL_STDC_STORE8_INLINE void
@@ -1365,30 +1365,30 @@ stdc_store8_leu8 (uint_least8_t value, unsigned char ptr[1])
 _GL_STDC_STORE8_INLINE void
 stdc_store8_leu16 (uint_least16_t value, unsigned char ptr[2])
 {
-  ptr[0] = (unsigned char) value & 0xFFU;
-  ptr[1] = (unsigned char) (value >> 8) & 0xFFU;
+  ptr[0] = value & 0xFFU;
+  ptr[1] = (value >> 8) & 0xFFU;
 }
 
 _GL_STDC_STORE8_INLINE void
 stdc_store8_leu32 (uint_least32_t value, unsigned char ptr[4])
 {
-  ptr[0] = (unsigned char) value & 0xFFU;
-  ptr[1] = (unsigned char) (value >> 8) & 0xFFU;
-  ptr[2] = (unsigned char) (value >> 16) & 0xFFU;
-  ptr[3] = (unsigned char) (value >> 24) & 0xFFU;
+  ptr[0] = value & 0xFFU;
+  ptr[1] = (value >> 8) & 0xFFU;
+  ptr[2] = (value >> 16) & 0xFFU;
+  ptr[3] = (value >> 24) & 0xFFU;
 }
 
 _GL_STDC_STORE8_INLINE void
 stdc_store8_leu64 (uint_least64_t value, unsigned char ptr[8])
 {
-  ptr[0] = (unsigned char) value & 0xFFU;
-  ptr[1] = (unsigned char) (value >> 8) & 0xFFU;
-  ptr[2] = (unsigned char) (value >> 16) & 0xFFU;
-  ptr[3] = (unsigned char) (value >> 24) & 0xFFU;
-  ptr[4] = (unsigned char) (value >> 32) & 0xFFU;
-  ptr[5] = (unsigned char) (value >> 40) & 0xFFU;
-  ptr[6] = (unsigned char) (value >> 48) & 0xFFU;
-  ptr[7] = (unsigned char) (value >> 56) & 0xFFU;
+  ptr[0] = value & 0xFFU;
+  ptr[1] = (value >> 8) & 0xFFU;
+  ptr[2] = (value >> 16) & 0xFFU;
+  ptr[3] = (value >> 24) & 0xFFU;
+  ptr[4] = (value >> 32) & 0xFFU;
+  ptr[5] = (value >> 40) & 0xFFU;
+  ptr[6] = (value >> 48) & 0xFFU;
+  ptr[7] = (value >> 56) & 0xFFU;
 }
 
 _GL_STDC_STORE8_INLINE void