]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: mana: validate rx_req_idx to prevent out-of-bounds array access
authorAditya Garg <gargaditya@linux.microsoft.com>
Wed, 20 May 2026 05:15:53 +0000 (22:15 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 21 May 2026 15:14:11 +0000 (08:14 -0700)
In mana_hwc_rx_event_handler(), rx_req_idx is derived from
sge->address in DMA-coherent memory. In Confidential VMs
(SEV-SNP/TDX), this memory is shared unencrypted and HW can modify
WQE contents at any time. No bounds check exists on rx_req_idx,
which can lead to an out-of-bounds access into reqs[].

Add bounds check on rx_req_idx in mana_hwc_rx_event_handler() before
using it to index the reqs[] array.

Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
Signed-off-by: Aditya Garg <gargaditya@linux.microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Link: https://patch.msgid.link/20260520051553.857120-1-gargaditya@linux.microsoft.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microsoft/mana/hw_channel.c

index fd8b324d7fb68795373240d705f6944b2d8bf710..e3c24d50dad07c65be9e94129dc09af9264f9f8d 100644 (file)
@@ -265,6 +265,12 @@ static void mana_hwc_rx_event_handler(void *ctx, u32 gdma_rxq_id,
        rq_base_addr = hwc_rxq->msg_buf->mem_info.dma_handle;
        rx_req_idx = (sge->address - rq_base_addr) / hwc->max_req_msg_size;
 
+       if (rx_req_idx >= hwc_rxq->msg_buf->num_reqs) {
+               dev_err(hwc->dev, "HWC RX: wrong rx_req_idx=%llu, num_reqs=%u\n",
+                       rx_req_idx, hwc_rxq->msg_buf->num_reqs);
+               return;
+       }
+
        rx_req = &hwc_rxq->msg_buf->reqs[rx_req_idx];
        resp = (struct gdma_resp_hdr *)rx_req->buf_va;